Add runtime extra instruction files to pvmap generator prompt#1972
Merged
rohitkumarbhagat merged 2 commits intodatacommonsorg:masterfrom Apr 27, 2026
Merged
Conversation
… PVMap generation prompt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to provide extra instruction files to the Gemini agent during the PVMap generation process. It includes new configuration flags, validation logic for file size and encoding, and updates to the prompt template to incorporate these instructions. Feedback was provided regarding the enforcement of working directory boundaries for these extra files to ensure they are accessible when sandboxing is enabled.
ajaits
reviewed
Apr 20, 2026
ajaits
approved these changes
Apr 20, 2026
Contributor
Author
|
Thanks Ajai for the feedback!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--extra_instruction_filesand--extra_instruction_max_bytestopvmap_generator.py